8000 ansible: upgrade test-digitalocean-fedora32-x64-1 by targos · Pull Request #3660 · nodejs/build · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@targos
Copy link
Member
@targos targos commented Mar 22, 2024

Replaced with test-digitalocean-fedora39-x64-1

Refs: #3350

Replaced with test-digitalocean-fedora39-x64-1
@targos
Copy link
Member Author
targos commented Mar 22, 2024

Note that after recreating the droplet, DNS resolution was broken. I had to do the following to fix it and be able to run the playbook:

vi /etc/systemd/resolved.conf with:

DNS=1.1.1.1#cloudflare-dns.com 1.0.0.1#cloudflare-dns.com 2606:4700:4700::1111#cloudflare-dns.com 2606:4700:4700::1001#cloudflare-dns.com

systemctl restart systemd-resolved

@targos
Copy link
Member Author
targos commented Mar 22, 2024

First host with this Fedora version, so let's do a test run before adding it to regular CI: https://ci.nodejs.org/view/All/job/node-test-commit-linux-targos-fedora39/1/

@richardlau
Copy link
Member

Note that after recreating the droplet, DNS resolution was broken. I had to do the following to fix it and be able to run the playbook:

vi /etc/systemd/resolved.conf with:

DNS=1.1.1.1#cloudflare-dns.com 1.0.0.1#cloudflare-dns.com 2606:4700:4700::1111#cloudflare-dns.com 2606:4700:4700::1001#cloudflare-dns.com

systemctl restart systemd-resolved

We've hit that before with DO droplets: #2745 (comment)

Copy link
Member
@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (subject to the CI run not uncovering any further issues)

@targos
Copy link
Member Author
targos commented Mar 22, 2024

CI passed.

@targos targos merged commit 51ad778 into main Mar 22, 2024
@targos targos deleted the fedora39 branch March 22, 2024 17:34
@richardlau
Copy link
Member
richardlau commented Mar 22, 2024

@targos FYI https://ci.nodejs.org/job/node-test-commit-linux/nodes=fedora-latest-x64/56783/console just failed on the machine (Node.js 18):

17:55:46 python3 ./configure --verbose 
17:55:46 Please use python3.11 or python3.10 or python3.9 or python3.8 or python3.7 or python3.6.
17:55:46 Node.js configure: Found Python 3.12.2...
17:55:46 make: *** [Makefile:569: build-ci] Error 1
17:55:46 Build step 'Execute shell' marked build as failure

We haven't backported the Python 3.12 compatibility patches to Node.js 18 -- I did look at those earlier this week but considered them risky for inclusion in 18.20.0 at the time.
I guess options are either to backport the patches (including the gyp-next update) or exclude fedora-latest for Node.js 18.

@richardlau
Copy link
Member
richardlau commented Mar 22, 2024

I'm running a test to see if we can just cherry-pick nodejs/node#50209 to Node.js 18 for now without the gyp-next changes from nodejs/node#50380. It looks like Python 3.12 on test-digitalocean-fedora39-x64-1 does still include/support distutils.version.

[root@test-digitalocean-fedora39-x64-1 ~]# python3
Python 3.12.2 (main, Feb 21 2024, 00:00:00) [GCC 13.2.1 20231205 (Red Hat 13.2.1-6)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import distutils.version
>>> print (distutils.version.StrictVersion("18.20.0") )
<stdin>:1: DeprecationWarning: distutils Version classes are deprecated. Use packaging.version instead.
18.20
>>>
[root@test-digitalocean-fedora39-x64-1 ~]#

https://ci.nodejs.org/job/node-test-commit-linux/56785/nodes=fedora-latest-x64/

@targos
Copy link
Member Author
targos commented Mar 23, 2024

Run looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0