8000 Add setTitle and title to QWindow by SleepyTealCoder · Pull Request #1062 · nodegui/nodegui · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@SleepyTealCoder
Copy link
  • Added setTitle, title functions and windowTitleChanged signal to QWindow. (https://doc.qt.io/qt-6/qwindow.html#title-prop)
  • Removed use of QApplication in WrapperCache tests as calling quit ends running of the tests - all tests in WrapperCache still pass with it removed.

@SleepyTealCoder
Copy link
Author

Hello. Apologies for the radio silence on my end.

I've noticed that the unit tests for Ubuntu 20.04 aren't running at the moment. Would be it worthwhile for me to look at why it isn't working on my end or if there's a potentially easy solution we can try?

@sedwards2009
Copy link
Collaborator

Sure, have a look at it. I suspect it is a dependency missing from the Ubuntu image. It would have to installed. I vaguely remember someone pointing out that some other X11 related package is needed sometimes.

@SleepyTealCoder SleepyTealCoder force-pushed the add-settitle-and-title-to-qwindow branch 3 times, most recently from ec59e86 to 84ad837 Compare April 23, 2025 22:54
… workflow under Ubuntu 20.04

Packages added:

libxcb-icccm4
libxcb-shape0
libxkbcommon-x11-0
libxcblibxcb-xkb1
libxcb-cursor0
libxcb-keysyms1
@SleepyTealCoder SleepyTealCoder force-pushed the add-settitle-and-title-to-qwindow branch from 84ad837 to 37cc3a9 Compare April 23, 2025 22:56
@SleepyTealCoder
Copy link
Author

Prior to approving the changed workflow some notes:

  • Following local testing of the actions using act and looking at the container it was using I've found that the libqxcb.so plugin was missing some dependencies - adding the libxcb-icccm4, libxcb-shape0, libxkbcommon-x11-0, libxcb-xkb1, libxcb-cursor0 & libxcb-keysyms1 packages fixed this issue.
  • Ran into an issue where qt.qpa.xcb: could not connect to display was happening until xvfb-run was added to the run tests step. xvfb is available in the runner image. Added a step for running the tests in Ubuntu like we do when fetching the packages. Hopefully the check for when we are not Ubuntu will behave itself on Windows & macOS builds.

As an alternative to the above we can set the environment variable QT_QPA_PLATFORM to offscreen in the Run tests step - this does work although it does complain about certain functions/features not being implemented.

Any further thoughts on the workflow changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0