8000 Add support for git_repository__cleanup by srajko · Pull Request #975 · nodegit/nodegit · GitHub
[go: up one dir, main page]

Skip to content

Add support for git_repository__cleanup#975

Merged
johnhaley81 merged 1 commit intonodegit:masterfrom
srajko:repository-cleanup
Mar 29, 2016
Merged

Add support for git_repository__cleanup#975
johnhaley81 merged 1 commit intonodegit:masterfrom
srajko:repository-cleanup

Conversation

@srajko
Copy link
Collaborator
@srajko srajko commented Mar 28, 2016

No description provided.

@srajko srajko changed the title [WIP] Add support for git_repository__cleanup Add support for git_repository__cleanup Mar 28, 2016
@srajko
Copy link
Collaborator Author
srajko commented Mar 28, 2016

The cleanup seems to be working nicely in conjunction with #958 - tested this in GitKraken and seeing memory usage improvements (as well as a lot more calls to git_commit__free) when changing repositories (and cleaning up the old repository when changing).

The advantage of cleanup over free is that cleanup leaves the repository object functioning, and that avoids problems with instances that still have a reference to the repo - this makes safer to call explicitly for the time being, when trying to address memory usage problems (until we get automatic memory management nailed down for all types).

@srajko srajko force-pushed the repository-cleanup branch from 015efd7 to ec97dbc Compare March 28, 2016 19:22
@johnhaley81
Copy link
Collaborator

LGTM, thanks @srajko

@johnhaley81 johnhaley81 merged commit 1a3610d into nodegit:master Mar 29, 2016
@johnhaley81 johnhaley81 deleted the repository-cleanup branch March 29, 2016 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0