8000 Add option to support longpaths on Windows by ianhattendorf · Pull Request #1748 · nodegit/nodegit · GitHub
[go: up one dir, main page]
Skip to content

Add option to support longpaths on Windows #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 14, 2020
Merged

Add option to support longpaths on Windows #1748

merged 9 commits into from
Jan 14, 2020

Conversation

ianhattendorf
Copy link
Member

See libgit2/libgit2#5347.

Option constants will be available once the PR is merged upstream. They are:

NodeGit.Libgit2.OPT.SET_WINDOWS_LONGPATHS === 28
NodeGit.Libgit2.OPT.GET_WINDOWS_LONGPATHS === 29

Can be called as:

// set longpaths on
NodeGit.Libgit2.opts(28, 1)
// check longpaths
const longpathsEnabled = NodeGit.Libgit2.opts(29)

implausible
implausible reviewed Jan 13, 2020
View reviewed changes
implausible
implausible requested changes Jan 14, 2020
View reviewed changes
Copy link
Member
@implausible implausible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if you made the following change, it would make this PR ideal.

@ianhattendorf
Default option return value to undefined
2a79ce9 
Don't return error value, instead throw on error
implausible
implausible approved these changes Jan 14, 2020
View reviewed changes
Copy link
Member
@implausible implausible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@implausible implausible merged commit 24a9fc4 into nodegit:master Jan 14, 2020
@snyk-bot snyk-bot mentioned this pull request Feb 23, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 12, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request May 5, 2020
Open
@rupreck rupreck mentioned this pull request Oct 14, 2020
Closed
@gpetrov
Copy link
gpetrov commented May 23, 2022

@ianhattendorf seems those options have disappeared in the latest Nodegit.

They were removed with a2897b9

Could you add them back or are they no longer required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@implausible implausible implausible approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ianhattendorf @gpetrov @implausible
0