8000 Fix linux 32-bit builds by johnhaley81 · Pull Request #1241 · nodegit/nodegit · GitHub
[go: up one dir, main page]
Skip to content

Fix linux 32-bit builds#1241

Merged
johnhaley81 merged 2 commits intomasterfrom
fix-linux-32
Feb 28, 2017
Merged

Fix linux 32-bit builds#1241
johnhaley81 merged 2 commits intomasterfrom
fix-linux-32

Conversation

@johnhaley81
Copy link
Collaborator
@johnhaley81 johnhaley81 commented Feb 27, 2017

No description provided.

@johnhaley81 johnhaley81 changed the title [WIP] Trying to figure out linux builds Fix linux 32-bit builds Feb 28, 2017
@johnhaley81
Copy link
Collaborator Author
johnhaley81 commented Feb 28, 2017

The builds were failing because somehow the sudo: required broke downloading packages off of apt-get (?!?) so removing that makes the build work again.

sudo was required because in order to build NodeGit on 32-bit linux we required a symlink to work around a bug introduced in gcc-multilib that renamed /usr/include/asm to /usr/include/asm-generic. That appears to be fixed so the work-around was no longer needed.

As an extra measure I added back in testing 32-bit builds for linux as well since they were removed originally.

@johnhaley81
Copy link
Collaborator Author
johnhaley81 commented Feb 28, 2017

image

@johnhaley81 johnhaley81 merged commit 450a337 into master Feb 28, 2017
@johnhaley81 johnhaley81 deleted the fix-linux-32 branch February 28, 2017 14:48
This was referenced Feb 28, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@johnhaley81
0