8000 Try re-enabling node >6.2 by maxkorp · Pull Request #1107 · nodegit/nodegit · GitHub
[go: up one dir, main page]

Skip to content

Conversation

@maxkorp
Copy link
Collaborator
@maxkorp maxkorp commented Aug 11, 2016

6.3 is working for me locally now, so trying this here.

@maxkorp
Copy link
Collaborator Author
maxkorp commented Aug 12, 2016

Interestingly, this works for me locally now (I got the same break appveyor is showing before, but now i don't get that with my last change).

Edit: User error. Def still broken >.<

@maxkorp maxkorp force-pushed the node-6.3 branch 2 times, most recently from 8f483d3 to 33d17cb Compare September 14, 2016 18:22
8000
@maxkorp
Copy link
Collaborator Author
maxkorp commented Sep 14, 2016

Depends on #1125

Not comfortable calling this the correct long term fix (not sure if it links to the built in or our own when both are available) but better than not building at all. Thanks to @implausible for helping find this.

@maxkorp maxkorp merged commit 167b57a into master Sep 14, 2016
@maxkorp maxkorp deleted the node-6.3 branch September 14, 2016 22:53
@maxkorp maxkorp changed the title Try re-enabling node 6.3 Try re-enabling node >6.2 Sep 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
549B

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0