chore: remove unused node-sql-parser dependency#13073
Open
guan404ming wants to merge 1 commit intonocodb:developfrom
Open
chore: remove unused node-sql-parser dependency#13073guan404ming wants to merge 1 commit intonocodb:developfrom
guan404ming wants to merge 1 commit intonocodb:developfrom
Conversation
|
|
b39c878 to
97d29db
Compare
Author
|
Hi @fendy3002 could you help take a look at this, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-sql-parserfrompackages/nocodb/package.jsonWhy
node-sql-parseris listed as a dependency but never imported anywhere in the codebase. It is also a large package, adding unnecessary weight to the install.Test plan
pnpm installcompletes without errors