8000 refactor: Chai assertions in test_back by paulmelnikow · Pull Request #1986 · nock/nock · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Chai assertions in test_back #1986

Merged
merged 4 commits into from
May 2, 2020
Merged

refactor: Chai assertions in test_back #1986

merged 4 commits into from
May 2, 2020
8000

Conversation

paulmelnikow
Copy link
Member

No description provided.

@paulmelnikow paulmelnikow requested a review from mastermatt May 2, 2020 04:22
@paulmelnikow
Copy link
Member Author

Looks like some timing-related flaky tests:

  1) `delayBody()`
       should delay the clock between the `response` event and the first `data` event:

      delay minimum not satisfied
      + expected - actual

      -199
      +200
      
      at checkDuration (tests/test_delay.js:34:33)
      at IncomingMessage.<anonymous> (tests/test_delay.js:113:9)
      at addChunk (_stream_readable.js:297:12)
      at readableAddChunk (_stream_readable.js:273:9)
      at IncomingMessage.Readable.push (_stream_readable.js:214:10)
      at ReadableBuffers.<anonymous> (lib/playback_interceptor.js:32:123)
      at ReadableBuffers.Readable.read (_stream_readable.js:508:10)
      at flow (_stream_readable.js:979:34)
      at resume_ (_stream_readable.js:960:3)
      at processTicksAndRejections (internal/process/task_queues.js:84:21)

@mastermatt
Copy link
Member

I've been trying to reproduce that issue in the tests locally for weeks. I only happens in GH actions near as I can tell.

@paulmelnikow
Copy link
Member Author

Yea gotcha. I can't get a clean build, though different builds are failing each time. I'll merge anyway.

@paulmelnikow paulmelnikow merged commit 3fc8d85 into beta May 2, 2020
@paulmelnikow paulmelnikow deleted the chai-back branch May 2, 2020 18:35
@weekly-digest weekly-digest bot mentioned this pull request May 3, 2020
Closed
@github-actions
Copy link

🎉 This PR is included in version 13.0.0-beta.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 13.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mastermatt mastermatt mastermatt approved these changes

Assignees
No one assigned
Labels
released on @beta released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulmelnikow @mastermatt
0