8000 fix an infinite loop in WS2812.cpp by kerikun11 · Pull Request #703 · nkolban/esp32-snippets · GitHub
[go: up one dir, main page]
Skip to content

fix an infinite loop in WS2812.cpp #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2018
+1 −1
Merged

fix an infinite loop in WS2812.cpp #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
BBF1
Diff view
2 changes: 1 addition & 1 deletion cpp_utils/WS2812.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ void WS2812::show() {
(getChannelValueByType(this->colorOrder[2], this->pixels[i]));

ESP_LOGD(LOG_TAG, "Pixel value: %x", currentPixel);
for (uint8_t j = 23; j >= 0; j--) {
for (int8_t j = 23; j >= 0; j--) {
// We have 24 bits of data representing the red, green amd blue channels. The value of the
// 24 bits to output is in the variable current_pixel. We now need to stream this value
// through RMT in most significant bit first. To do this, we iterate through each of the 24
Expand Down
0