Release memory from CLASSIC_BT when not enabled #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a FIXME marker, stating that reply is pending from esp-idf team. Seems like issue has been resolved and we can use
esp_bt_controller_mem_releasesafely now. (espressif/esp-idf#1162)I have removed the
esp_bt_controller_enable(ESP_BT_MODE_BLE)as it causes BT controller failing to start when config hasCLASSIC_BT_ENABLED=y. There's no moreESP_BT_MODE_BLE, onlyESP_BT_MODE_BTDM, therefore I've cut out most of#ifndefblock. (espressif/esp-idf#405)