10000 PubSub: pass pdTRUE instead of true by toxuin · Pull Request #695 · nkolban/esp32-snippets · GitHub
[go: up one dir, main page]
Skip to content

PubSub: pass pdTRUE instead of true #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2018
Merged

PubSub: pass pdTRUE instead of true #695

merged 1 commit into from
Oct 14, 2018

Conversation

toxuin
Copy link
Contributor
@toxuin toxuin commented Oct 14, 2018

Also, PubSubClient::readPacket returns a uint16_t where it should be returning a size_t (number of bytes read).

@nkolban nkolban merged commit def0952 into nkolban:master Oct 14, 2018
@toxuin toxuin deleted the pubsub-args branch October 14, 2018 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toxuin @nkolban
0