Common code style #691
Merged
Common code style #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toxuin
commented
Oct 14, 2018
Force gcc to ignore unused-but-set-parameter Fix line misplacement by merge Cast string data to uint8_t pointer Fix line mangling on merge Fix line mangling on merge Fix line mangling on merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
This PR does not add any functionality, just cleans up the code.
This makes code more readable and understandable, also since it's done at once, it should be quite consistent across the codebase now.
This cleans out typos, adds spaces to loops, replaces spaces with tabs at the beginning of the line, distinguishes pointers (
int* myVar) and pointing to a variable (*myVar), etc.I know things like this are a matter of preference, so I am open to critic and ready to change things around.
This is a bigger PR, so it would be great if more than one person would review it.