8000 FIX: BLESecurity.h -> BLESecurityCallbacks. by joaoc · Pull Request #594 · nkolban/esp32-snippets · GitHub
[go: up one dir, main page]
Skip to content

FIX: BLESecurity.h -> BLESecurityCallbacks. #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2018
Merged

FIX: BLESecurity.h -> BLESecurityCallbacks. #594

merged 1 commit into from
Jul 10, 2018

Conversation

joaoc
Copy link
Contributor
@joaoc joaoc commented Jul 5, 2018

Make all the methods pure virtual.
Some of the methods were virtual, but without local definitions,
this creates an error during linking.

I think there shouldn't be any default behavior for this class.

This will fix issue #412

@joaoc
FIX: BLESecurity.h -> BLESecurityCallbacks.
d6ef149 
Make all the methods pure virtual.
Some of the methods were virtual, but without local definitions,
this creates an error during linking.
@nkolban nkolban merged commit 8980fb1 into nkolban:master Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaoc @nkolban
0