-
Notifications
You must be signed in to change notification settings - Fork 60
Hash change guards #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Hash change guards #698
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
3a72666
Implemented hash-change guards in TaskBase._run()
tclose b378f83
added hash guards to workflow execution (i.e. on workflow inputs)
tclose 5aaf62f
reworked error message for blocked upstream tasks to specifiy which t…
tclose 0397a18
touched up messages for hash change errors
tclose 1d77f4b
replaced attrs.evolve with manual setattr of inputs within Task._run(…
tclose e2d009b
updated explicit hashes in unittests to match new values produced by …
tclose 48d68f5
added a sleep to alter_x to make sure it runs after identity
tclose 1a9eed0
fix up
tclose d76bb3d
[skip ci] updates comment
tclose 6e1f030
upped sleep
tclose 6717d85
added random in to ensure that alter_x finishes after identity
tclose 1cd9491
added more reruns to test_hash_changes_in_workflow_graph
tclose 7d6849b
fixed bugs in graph hash error test
tclose df9ecc6
added logging to assist in tracking down hashing issues
tclose 930dfc1
[skip ci] touched up error message
tclose 6128951
added docstring to bytes_repr to retrigger checks
tclose 4ba8da0
updated bytes_repr doc string
tclose 15a775d
removed check for result None in TaskBase._run(). Shouldn't occur now…
tclose 1263f5a
added test to hit unstable hash check branch
tclose b54166e
expanded hash graph error message to include final values/hashes of p…
tclose 048c0a1
More touch ups to error messages
tclose c282d3e
Update pydra/engine/tests/test_submitter.py
tclose 509afc7
Update pydra/engine/tests/test_submitter.py
tclose 6e91065
reworked hash change detection error messages
tclose 9896735
modified modified inputs so it returns the actual original inputs not…
tclose e660351
changed deepcopy to copy in checksum_states (not sure whether this is…
tclose 8a5541c
changed test_hash_changes unittest so it works with python 3.8
tclose 4e1d4a8
changed _graph_checksums to a dict instead of a list
tclose b94f185
Merge branch 'master' into hash-change-guards
tclose ff281aa
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added hash guards to workflow execution (i.e. on workflow inputs)
- Loading branch information
commit b378f83105aedbc45fd1cd47c3dd081d4b1dce49
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.