8000 Update DOCKER_IMAGE tag in testslurm.yml by adi611 · Pull Request #697 · nipype/pydra · GitHub
[go: up one dir, main page]
Skip to content

Update DOCKER_IMAGE tag in testslurm.yml #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Sep 18, 2023
Merged

Update DOCKER_IMAGE tag in testslurm.yml #697

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
18cd7ba
Update testslurm.yml
adi611 Sep 8, 2023
d171f6b
Update testslurm.yml
adi611 Sep 8, 2023
d910c93
test with new image
satra Sep 11, 2023
e286273
remove adding cluster in slurm
satra Sep 11, 2023
5499861
fix: execute slurm command inside container
satra Sep 11, 2023
73b1cf3
fix: set python 3.9 to be global
satra Sep 11, 2023
368600c
trying running global in all commands.
satra Sep 11, 2023
61fb722
drop version specific call
satra Sep 11, 2023
5168155
remove `-n auto` from pytest command
adi611 Sep 12, 2023
10548b0
check for all python versions for the container
adi611 Sep 14, 2023
06276d8
add python version 3.11.5
adi611 Sep 15, 2023
12c65d6
remove python 3.11.1
adi611 Sep 15, 2023
afeb705
exclude python 3.11.1 in `pyproject.toml`
adi611 Sep 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions .github/workflows/testslurm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ on:

jobs:
build:
strategy:
matrix:
python-version: [3.8.16, 3.9.16, 3.10.9, 3.11.5]
fail-fast: false
runs-on: ubuntu-latest
env:
DOCKER_IMAGE: giovtorres/docker-centos7-slurm:latest
DOCKER_IMAGE: adi611/docker-centos7-slurm:23.02.1

steps:
- name: Disable etelemetry
Expand All @@ -24,10 +28,7 @@ jobs:
- name: Display previous jobs with sacct
run: |
echo "Allowing ports/daemons time to start" && sleep 10
docker exec slurm bash -c "sacctmgr -i add cluster name=linux \
&& supervisorctl restart slurmdbd \
&& supervisorctl restart slurmctld \
&& sacctmgr -i add account none,test Cluster=linux Description='none' Organization='none'"
docker exec slurm bash -c "sacctmgr -i add account none,test Cluster=linux Description='none' Organization='none'"
docker exec slurm bash -c "sacct && sinfo && squeue" 2&> /dev/null
if [ $? -ne 0 ]; then
echo "Slurm docker image error"
Expand All @@ -38,12 +39,16 @@ jobs:
docker exec slurm bash -c "echo $NO_ET"
docker exec slurm bash -c "ls -la && echo list top level dir"
docker exec slurm bash -c "ls -la /pydra && echo list pydra dir"
docker exec slurm bash -c "pip3.9 install --upgrade pip && pip3.9 install -e /pydra[test] && python3.9 -c 'import pydra; print(pydra.__version__)'"
if [[ "${{ matrix.python-version }}" == "3.11.5" ]]; then
docker exec slurm bash -c "CONFIGURE_OPTS=\"-with-openssl=/opt/openssl\" pyenv install -v 3.11.5"
fi
docker exec slurm bash -c "pyenv global ${{ matrix.python-version }}"
docker exec slurm bash -c "pip install --upgrade pip && pip install -e /pydra[test] && python -c 'import pydra; print(pydra.__version__)'"
- name: Run pytest
run: |
docker exec slurm bash -c "pytest --color=yes -vs -n auto --cov pydra --cov-config /pydra/.coveragerc --cov-report xml:/pydra/cov.xml --doctest-modules /pydra/pydra/ -k 'not test_audit_prov and not test_audit_prov_messdir_1 and not test_audit_prov_messdir_2 and not test_audit_prov_wf and not test_audit_all'"
docker exec slurm bash -c "pytest --color=yes -vs --cov pydra --cov-config /pydra/.coveragerc --cov-report xml:/pydra/cov.xml --doctest-modules /pydra/pydra/ -k 'not test_audit_prov and not test_audit_prov_messdir_1 and not test_audit_prov_messdir_2 and not test_audit_prov_wf and not test_audit_all'"
- name: Upload to codecov
run: |
docker exec slurm bash -c "pip3.9 install urllib3==1.26.6"
docker exec slurm bash -c "pip install urllib3==1.26.6"
docker exec slurm bash -c "codecov --root /pydra -f /pydra/cov.xml -F unittests"
docker rm -f slurm
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ build-backend = "flit_scm:buildapi"
name = "pydra"
description = "Pydra dataflow engine"
readme = "README.rst"
requires-python = ">=3.8"
requires-python = ">=3.8, !=3.11.1"
dependencies = [
"attrs >=19.1.0",
"cloudpickle >=2.0.0",
Expand Down
0