ENH: Add support for argstr formatting of any iterable #614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c4c022 to
1985e96
Compare
c877ee6 to
3424174
Compare
|
I took this opportunity to fix a few typos and warnings which PyCharm complained about. |
Codecov ReportBase: 81.23% // Head: 81.16% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 81.23% 81.16% -0.07%
==========================================
Files 20 20
Lines 4391 4391
Branches 1262 1262
==========================================
- Hits 3567 3564 -3
- Misses 820 823 +3
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sets don't preserve order of insertion, unlike tuples and lists.
|
LGTM. |
|
Is it ok if I merge this? |
|
yes, sorry, thank you! I will create a new release during the weekend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #613 for context. I looked at the code path @effigies suggested where the fix should be implemented.
This PR should facilitate composition of interfaces producing and consuming iterable types, not just lists. Sets and tuples provide additional guarantees which are quite nice, such as uniqueness and size boundness respectively. Since strings and bytes also satisfy the
Iterableprotocol in Python, these need to be discarded explicitly in the instance type check.Closes #613