RF: Replace OneTimeProperty/auto_attr with cached_property #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1341 +/- ##
=======================================
Coverage 95.34% 95.34%
=======================================
Files 207 207
Lines 29084 29081 -3
Branches 4863 4863
=======================================
- Hits 27730 27728 -2
Misses 923 923
+ Partials 431 430 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type annotations of
nibabel.onetime.OneTimePropertyhave stopped checking with recent mypy. Given that this is redundant withfunctools.cached_property, it seems cleaner just to replace these synonyms directly withcached_property.Also grabbed a test from nitime to verify that partial resets succeed.
Small fix for building docs with 3.12 en passant.