TYP: Annotate loadsave and image header classes #1213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 98 98
Lines 12366 12372 +6
Branches 2545 2543 -2
=======================================
+ Hits 11397 11403 +6
Misses 646 646
Partials 323 323
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ZviBaratz
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nb.load()and (to some extent)nb.save()are probably the most used functions. They should have some signatures, though the usefulness is bounded as the type checker can't infer the resulting type from the filename.While testing this on a code base I'm writing to be type-checked from the start, I found that everything declared itself as having a
FileBasedHeader, which is not very useful. I can't come up with something type-variable-ish so that we can deduplicate these and rely on theheader_class, but oh well.