-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use python3 instead of python #2118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As stated on the previous PR, python3 isn't on this CI job that failed. I could either continue letting that CI run python2, or we could try to update that CI infra to contain python3. What would be preferred (for now I'm going with option 1 to get green CI). https://ci.appveyor.com/project/nico/ninja/builds/43291919/job/yby9glo98np8tfrf |
5c9e435
to
6c3e941
Compare
IMHO this is a bug and should be reported to Apple, no workaround in Ninja or any other software. |
This comment was marked as abuse.
This comment was marked as abuse.
I don't think this should be considered a bug. It was definitely intentional on the Apple side, as it was included in the release notes for macOS 12.3: My assumption is that they didn't want to maintain a Regardless of Apple's decisions here, the related pep https://peps.python.org/pep-0394/ (which isn't accepted, but seems to have general consensus python/peps#989) states that distributions should have So my assumption is that over time we will see fewer and fewer users who have a In general I think if we believe that python3 will be more widely installed than python2, even if folks did still have this symlink, it makes sense to default to the more widely used version, and folks can continue to manually run |
I disagree with the PEP, too :D |
6c3e941
to
aad84b3
Compare
Note: it's not just Mac OS that's removing /usr/bin/python by default, debian 11 does that too: https://wiki.debian.org/Python |
I don't think |
This is a new version of ninja-build#2063 for discussion. macOS 12.3 has removed /usr/bin/python entirely, so there is no longer an executable if you request `/usr/bin/env python`. So even if you override `--with-python=python3`, you cannot call `./configure.py` directly, you'd have to run `python3 configure.py` instead.
aad84b3
to
6bfe5c4
Compare
It looks like debian has officially removed the python 2 packages https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027108 |
fixed by 6a17e84 |
It looks like there were a few in this PR that aren't in that commit, I submitted #2241 |
This is a new version of #2063
for discussion. macOS 12.3 has removed /usr/bin/python entirely, so
there is no longer an executable if you request
/usr/bin/env python
.So even if you override
--with-python=python3
, you cannot call./configure.py
directly, you'd have to runpython3 configure.py
instead.