-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errata in examples 2.1 and 2.4 #1130
Comments
The idea of this section being that more focussed on how to do feature selection procedure providing an idea. For me, I think user will know the meaning of X and y in fit and predict (as it explained above).
Thanks for spotting. PR welcome. :) |
Ok, I'll do a PR |
On Tue, Jun 14, 2016 at 11:05 PM, Joao Loula notifications@github.com
Elvis Dohmatob, |
It looks like the link issues were resolved in #1184, so now the only problem is that Example 2.1 (An introduction to decoding) does not define the variables used in section 2.1.3.1 (Dimension reduction with feature selection)- specifically The example uses the following lines from nilearn/examples/02_decoding/plot_haxby_anova_svm.py Lines 56 to 86 in 0c6388a
|
In section 2.1.3.1, the pipeline model is used to fit and predict X and y variables that weren't declared before in the tutorial: it seems these were taken from the example plot_haxby_anova_svm.py, so something like this should probably be added:
mask_filename = haxby_dataset.mask
nifti_masker = NiftiMasker(mask_img=mask_filename, standardize=True)
func_filename = haxby_dataset.func[0]
X = nifti_masker.fit_transform(func_filename)
X = X[condition_mask]
with eventually a change in the name of the mask variables just to make it clear that they're different from those used at the beginning of the section. The y variable can just be replaced with the target variable declared before.
In the first paragraph of section 2.4.1, both links to [Grosenick et al. 2013] redirect to [Gramfort et al. 2013], they should probably be changed to http://www.ncbi.nlm.nih.gov/pubmed/23298747.
The text was updated successfully, but these errors were encountered: