8000 [HttpFoundation] Same site cookie by cvilleger · Pull Request #17 · nicolas-grekas/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpFoundation] Same site cookie #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

[HttpFoundation] Same site cookie #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
12aa1cd
[HttpFoundation] Add functional tests for Response::sendHeaders()
cvilleger Apr 5, 2018
4f29d5c
Add requires PHP 7.0 for RequestFunctionalTest
cvilleger Apr 6, 2018
bb0b7d0
Add invalid cookie name test for RequestFunctionalTest
cvilleger Apr 6, 2018
f6e9293
Add cookie urlencode tests for name and value
cvilleger Apr 6, 2018
b166bd6
Add testcookieShouldUrlEncode with native case
cvilleger Apr 6, 2018
1e85119
Add tests for cookie symfony vs php native
cvilleger Apr 6, 2018
cb95976
Doing as PHP without urlencode Cookie name
cvilleger Apr 6, 2018
2d4c638
Revert Cookie name toString and fix tests
cvilleger Apr 6, 2018
9d7ed67
Rename max-age to Max-Age to be iso to PHP and transform negative val…
cvilleger Apr 6, 2018
a81574b
Fix invalid cookie error message
cvilleger Apr 6, 2018
b40e53d
Add test for cookie max-age
cvilleger Apr 19, 2018
File filter

Filter by extension

Filter by extension 8000
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert Cookie name toString and fix tests
  • Loading branch information
@cvilleger
cvilleger committed Apr 6, 2018
commit 2d4c638fc060bde1fd5d6dd610d3dca70d67497d
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpFoundation/Cookie.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ public function __construct($name, $value = null, $expire = 0, $path = '/', $dom
*/
public function __toString()
{
$str = $this->getName().'=';
$str = ($this->isRaw() ? $this->getName() : urlencode($this->getName())).'=';

if ('' === (string) $this->getValue()) {
$str .= 'deleted; expires='.gmdate('D, d-M-Y H:i:s T', time() - 31536001).'; max-age=-31536001';
Expand Down
4 changes: 2 additions & 2 deletions ...Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_raw_urlencode.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Array
[0] => Content-Type: text/plain; charset=utf-8
[1] => Cache-Control: no-cache, private
[2] => Date: Sat, 12 Nov 1955 20:04:00 GMT
[3] => Set-Cookie: https://blackfire.io/?*():@&+$/%#[]=https://blackfire.io/?*():@&+$/%#[]; path=/
[4] => Set-Cookie: https://blackfire.io/?*():@&+$/%#[]=https://blackfire.io/?*():@&+$/%#[]; path=/
[3] => Set-Cookie: ?*():@&+$/%#[]=?*():@&+$/%#[]; path=/
[4] => Set-Cookie: ?*():@&+$/%#[]=?*():@&+$/%#[]; path=/
)
shutdown
6 changes: 3 additions & 3 deletions ...fony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_raw_urlencode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

$r = require __DIR__ . '/common.inc';

$url = 'https://blackfire.io/?*():@&+$/%#[]';
$str = '?*():@&+$/%#[]';

$r->headers->setCookie(new Cookie($url, $url, 0, '/', null, false, false, true));
$r->headers->setCookie(new Cookie($str, $str, 0, '/', null, false, false, true));
$r->sendHeaders();

setrawcookie($url, $url, 0, '/', null, false, false);
setrawcookie($str, $str, 0, '/', null, false, false);
4 changes: 2 additions & 2 deletions ...ony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_urlencode.expected
8000
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Array
[0] => Content-Type: text/plain; charset=utf-8
[1] => Cache-Control: no-cache, private
[2] => Date: Sat, 12 Nov 1955 20:04:00 GMT
[3] => Set-Cookie: https://blackfire.io/?*():@&+$/%#[]=https%3A%2F%2Fblackfire.io%2F%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
[4] => Set-Cookie: https://blackfire.io/?*():@&+$/%#[]=https%3A%2F%2Fblackfire.io%2F%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
[3] => Set-Cookie: %3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
[4] => Set-Cookie: ?*():@&+$/%#[]=%3F%2A%28%29%3A%40%26%2B%24%2F%25%23%5B%5D; path=/
)
shutdown
6 changes: 3 additions & 3 deletions src/Symfony/Component/HttpFoundation/Tests/Fixtures/response-functional/cookie_urlencode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@

$r = require __DIR__ . '/common.inc';

$url = 'https://blackfire.io/?*():@&+$/%#[]';
$str = '?*():@&+$/%#[]';

$r->headers->setCookie(new Cookie($url, $url, 0, '', null, false, false));
$r->headers->setCookie(new Cookie($str, $str, 0, '', null, false, false));
$r->sendHeaders();

setcookie($url,$url, 0, '/');
setcookie($str, $str, 0, '/');
0