Updated dialog_manager to send EoC code like dialog_extensions. (microsoft#1504)

gabog · web-flow · commit 354444ef38c3 · 2021-02-05T00:43:20.000-08:00
Also added checks in the test fo ensure we get the code back
diff --git a/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_manager.py b/libraries/botbuilder-dialogs/botbuilder/dialogs/dialog_manager.py
@@ -16,7 +16,7 @@
     DialogStateManager,
     DialogStateManagerConfiguration,
 )
-from botbuilder.schema import Activity, ActivityTypes
+from botbuilder.schema import Activity, ActivityTypes, EndOfConversationCodes
 from botframework.connector.auth import (
     AuthenticationConstants,
     ClaimsIdentity,
@@ -355,6 +355,9 @@ async def handle_skill_on_turn(
                 type=ActivityTypes.end_of_conversation,
                 value=turn_result.result,
                 locale=turn_context.activity.locale,
+                code=EndOfConversationCodes.completed_successfully
+                if turn_result.status == DialogTurnStatus.Complete
+                else EndOfConversationCodes.user_cancelled,
             )
             await turn_context.send_activity(activity)
 
diff --git a/libraries/botbuilder-dialogs/tests/test_dialog_manager.py b/libraries/botbuilder-dialogs/tests/test_dialog_manager.py
@@ -38,6 +38,7 @@
     ActivityTypes,
     ChannelAccount,
     ConversationAccount,
+    EndOfConversationCodes,
     InputHints,
 )
 from botframework.connector.auth import AuthenticationConstants, ClaimsIdentity
@@ -237,6 +238,10 @@ async def test_handles_bot_and_skills(self):
                         SimpleComponentDialog.eoc_sent.type,
                         ActivityTypes.end_of_conversation,
                     )
+                    self.assertEqual(
+                        SimpleComponentDialog.eoc_sent.code,
+                        EndOfConversationCodes.completed_successfully,
+                    )
                     self.assertEqual(SimpleComponentDialog.eoc_sent.value, "SomeName")
                 else:
                     self.assertIsNone(
