8000 Updated dialog_manager to send EoC code like dialog_extensions. by gabog · Pull Request #1504 · microsoft/botbuilder-python · GitHub
[go: up one dir, main page]
Skip to content
8000

Updated dialog_manager to send EoC code like dialog_extensions. #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2021
Merged

Updated dialog_manager to send EoC code like dialog_extensions. #1504

merged 1 commit into from
Feb 5, 2021

Conversation

gabog
Copy link
Contributor
@gabog gabog commented Feb 5, 2021

Also added checks in the test fo ensure we get the code back

Fixes #1502

@gabog
Updated dialog_manager to send EoC code like dialog_extensions.
c959cea 
Also added checks in the test fo ensure we get the code back
@gabog gabog requested a review from axelsrz February 5, 2021 05:35
@axelsrz axelsrz merged commit 354444e into main Feb 5, 2021
@axelsrz axelsrz deleted the gabog/FixDialogManagerToReturnEoCCode branch February 5, 2021 08:43
@axelsrz axelsrz mentioned this pull request Jun 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DialogManager does not return EoC code when a dialog ends (python)
2 participants
@gabog @axelsrz
0