@strict-csp/builder package + middleware fixes for Vercel #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for all aspects like create, manipulate, merge, ... + typings independent of any framework
test: run with --passWithNoTests existing unit tests moved to builder package
include ws: and wss: scheme soruces for for Webpack HMR
to avoid excess script hashes when preemptively register loaders for ISR (due to different async/defer true/false combinations) Can be safely reduced by filtering out falsy attribute values before, as just not setting the attribute means false refactor: move code to remove circular dependency fix(rollup): get rid of rollup warnings fix(rollup): list all external modules explicitly for each bundle
fix: avoid Promise.all. - await manifest, cspbuilder and config and run finalize sequentially fix: avoid module-level cache variable for global cache - cache within memoize function scope - on Vercel, sometimes a manifest of a different deployment got inserted!
Commit generated via `yarn stage`
has important routing bug fixes related to middleware, see #34 (comment)
🦋 Changeset detectedLatest commit: 8283af8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
...and non-empty CSP. This led to a bug with on-demand ISR on Vercel, where the styles overwrote the actual CSP from middleware with some styles only. refactor(document): remove unused file modules
|
Manually tested the e2e app with a real iPad Pro device on Safari >=15.4 with 53db2380-d51f-4c64-993d-41255b5c5d22.mp1659709812286.mp4Notes:
|
Open
This was referenced May 26, 2023
This was referenced May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first step of #66