feat: added clients for systems management service create virtual system, remove systems and query system API #138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbell517 Please review this pull request, when you are available |
rbell517
requested changes
May 22, 2025
nisystemlink/clients/systems/models/_create_virtual_systems_request.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/systems/models/_create_virtual_systems_response.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/systems/models/_remove_systems_response.py
Outdated
Show resolved
Hide resolved
…vindhan-ni/nisystemlink-clients-python into users/ammar/feat/systems_api
added 2 commits
May 23, 2025 17:51
rbell517
approved these changes
May 23, 2025
|
@rbell517 Please go ahead and merge the PR if there are no further comments or concerns. |
…k-clients-python into users/ammar/feat/systems_api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Added create virtual system, remove and query system APIs in System Management service.
Why should this Pull Request be merged?
This systems client will improve user interactivity with those System Management Service endpoints.
What testing has been done?
Automated integration tests are included.
API Link: Swagger-link
Note
Added only limited fields for the systems query response since, we don't have a fixed response type for system.
Regarding this we already had discussion please refer this.
Also, Here is the Draft PR for your reference.