10000 fix(signals): skip assertions when ngDevMode is not defined by markostanimirovic · Pull Request #4703 · ngrx/platform · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(signals): skip assertions when ngDevMode is not defined #4703

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix(signals): skip assertions when ngDevMode is not defined #4703

merged 1 commit into from
Feb 14, 2025

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Error is thrown when the ngDevMode global variable is not defined.

Closes #4699

What is the new behavior?

SignalStore assertions are skipped when the ngDevMode global variable is not defined.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify Netlify
Copy link
netlify bot commented Feb 12, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit a7570ca
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67ac7058e9fd9400087ada48

@timdeschryver timdeschryver merged commit 0b43014 into main Feb 14, 2025
10 checks passed
@timdeschryver timdeschryver deleted the fix/signals/undefined-ngDevMode branch February 14, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ngDevMode is undefined in an MFE with external or shared dependencies
3 participants
@markostanimirovic @brandonroberts @timdeschryver
0