8000 ci: disable deploy step by timdeschryver · Pull Request #4696 · ngrx/platform · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable deploy step #4696

Merged
merged 1 commit into from
Feb 12, 2025
Merged

ci: disable deploy step #4696

merged 1 commit into from
Feb 12, 2025

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The build is red due to the ssh step.

What is the new behavior?

The deploy step is disabled, because we like green builds.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

We will have to figure out how to re-enable the deploy step (do we need the deploy key? can we use an action for this step? ...?).

I don't know an easy/quick way to test this, maybe that we can include these steps in the CI build to shorten the feedback loop? Once it works we can revert the changes to the CI build, and update the main build.

@netlify Netlify
Copy link
netlify bot commented Feb 5, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit becc929
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67a3b379be282f0008828fdb

@brandonroberts brandonroberts merged commit 425cc0e into main Feb 12, 2025
10 checks passed
@brandonroberts brandonroberts deleted the ci/disable-deploy branch February 12, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timdeschryver @brandonroberts @markostanimirovic
0