8000 ci: deploy nightly builds by timdeschryver · Pull Request #4685 · ngrx/platform · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: deploy nightly builds #4685

Merged
merged 1 commit into from
Feb 4, 2025
Merged

ci: deploy nightly builds #4685

merged 1 commit into from 8000
Feb 4, 2025

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[x] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4507

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR pushes the dist folders to the nightly build repositories using the deploy step.
The additional changes in the commit is because I switched the build and the schematics-core-check in order, to keep the deploy close to the build step.

I did not test this, I assume webfactory/ssh-agent@v0.9.0 does the same as setting the fingerprint with CicleCi.

timdeschryver
timdeschryver commented Jan 26, 2025
View reviewed changes
build/deploy-build.ts
@@ -4,7 +4,7 @@ import { packages } from './config';

const deploy = createBuilder([
['Deploy builds', tasks.publishToRepo],
['Deploy docs', tasks.publishDocs],
// ['Deploy docs', tasks.publishDocs],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brandonroberts do you think this is still required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. We use it for https://next.ngrx.io but I don't know that its heavily used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I haven't thought of that.
Would you be OK with doing that in a next PR? After we're sure that the current nightlies are working.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@netlify Netlify
Copy link
netlify bot commented Jan 26, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 43cf182
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/67960657a1e81f0009070047

@brandonroberts brandonroberts merged commit 2266140 into main Feb 4, 2025
10 checks passed
@brandonroberts brandonroberts deleted the ci/deploy-nightly-builds branch February 4, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

@markostanimirovic markostanimirovic markostanimirovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate our pipelines
3 participants
@timdeschryver @brandonroberts @markostanimirovic
0