10000 chore: replace .nvmrc with .node-version for better compatibility by JeevanMahesha · Pull Request #4657 · ngrx/platform · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace .nvmrc with .node-version for better compatibility #4657

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore: replace .nvmrc with .node-version for better compatibility #4657

merged 2 commits into from
Jan 6, 2025

Conversation

JeevanMahesha
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

The .nvmrc file is specific to nvm (Node Version Manager) and does not support other modern Node.js version managers like fnm, Volta, or asdf. By switching to .node-version, we align the repository with a more universally supported standard, making it easier for contributors using different tools to manage Node.js versions.

  • Build related changes

Does this PR introduce a breaking change?

  • Yes
  • No

@netlify Netlify
Copy link
netlify bot commented Jan 4, 2025 •
edited
Loading

✅ Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3b50804
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/677aad1aa94dff000876d0b4

@JeevanMahesha
< 10000 div class="ml-n3 timeline-comment unminimized-comment comment previewable-edit js-task-list-container js-comment timeline-comment--caret" data-body-version="21d4fbb4e95b659bea9c16e5dae8275e5b14816e9bf71aaa60b9bb69d284b79d">
Copy link
Contributor Author

@rainerhahnekamp can you please review this PR.

rainerhahnekamp
rainerhahnekamp approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor
@rainerhahnekamp rainerhahnekamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense; the only downside (according to ChatGPT) of .node-version is that we cannot use values like lts.
Since we have fixed versions, it is OK for me to switch to .node-version.

@JeevanMahesha
Copy link
Contributor Author

@markostanimirovic can you please review this PR.

timdeschryver
timdeschryver requested changes Jan 5, 2025
View reviewed changes
Copy link
Member
@timdeschryver timdeschryver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also update the our CI pipelines (there are multiple references to this file within each pipeline).

@timdeschryver timdeschryver merged commit 3803550 into ngrx:main Jan 6, 2025
5 checks passed
@JeevanMahesha JeevanMahesha deleted the chore/replace-nvmrc-with-node-version branch January 8, 2025 04:00
rainerhahnekamp pushed a commit to rainerhahnekamp/ngrx that referenced this pull request Jan 20, 2025
@JeevanMahesha @rainerhahnekamp
build: replace .nvmrc with .node-version for better compatibility (ng…
bf25029 
…rx#4657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainerhahnekamp rainerhahnekamp rainerhahnekamp approved these changes

@timdeschryver timdeschryver timdeschryver approved these changes

@markostanimirovic markostanimirovic Awaiting requested review from markostanimirovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JeevanMahesha @rainerhahnekamp @timdeschryver
0