8000 fix: address grafana config (#87) and aws/pulumi issues (#94) by qdzlug · Pull Request #95 · nginxinc/kic-reference-architectures · GitHub
[go: up one dir, main page]
Skip to content

fix: address grafana config (#87) and aws/pulumi issues (#94) #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2022
Merged

fix: address grafana config (#87) and aws/pulumi issues (#94) #95

merged 3 commits into from
Feb 16, 2022

Conversation

qdzlug
Copy link
Contributor
@qdzlug qdzlug commented Feb 16, 2022

Proposed changes

This change closes two issues:

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

Jason Schmidt added 3 commits February 15, 2022 16:38
c33eb99 
fix: address nginxinc#87 remove standalone grafana config
895161e 
fix: change where we pull grafana password from
a03518e 
fix: address pulumi issues in nginxinc#94
@qdzlug qdzlug requested a review from dekobon February 16, 2022 15:49
@qdzlug qdzlug merged commit 2a3c319 into nginxinc:master Feb 16, 2022
@qdzlug qdzlug deleted the grafana-fix branch February 16, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dekobon dekobon dekobon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: issues with pulumi configuration and aws startup fix: remove deprecated grafana config options
2 participants
@qdzlug @dekobon
0