8000 refactor: move .python-version file to the root, increase patch version by 4141done · Pull Request #144 · nginxinc/kic-reference-architectures · GitHub
[go: up one dir, main page]
Skip to content
This repository was archived by the owner on Oct 8, 2025. It is now read-only.

refactor: move .python-version file to the root, increase patch version #144

Merged
merged 1 commit into from
May 12, 2022
Merged

refactor: move .python-version file to the root, increase patch version #144

merged 1 commit into from
May 12, 2022

Conversation

4141done
Copy link
Contributor
@4141done 4141done commented May 10, 2022 •
edited
Loading

Most version managers interpret the .python-version file from the root and apply the
python version specified to all child folders. Moving the .pythong-version file
to the root of the project ensures that the python version is the same for all
actions, but most importantly avoids a situation when running ./bin/setup_venv.sh
from the root where the system python will be hooked for the venv.

Proposed changes

  • Move .python-version file to root
  • Update python version to 3.9.12 as 3.9.6 fails to build on M1 macs. Happy to walk back this change if we think it's not a good enough reason to mess with the version required.

Example

$./bin/setup_venv.sh
# ...
$ source pulumi/python/venv/bin/activate
(venv) 
$ python --version
Python 3.9.12
(venv)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have r 8000 ead the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@4141done 4141done force-pushed the change-venv-location branch from c2509a6 to ff3deeb Compare May 10, 2022 17:44
@4141done
refactor: move .python-version file to the root, increase patch version
b3a2c10 
Most version managers interpret the `.python-version` file from the root and apply the
python version specified to all child folders.  Moving the `.pythong-version` file
to the root of the project ensures that the python version is the same for all
actions, but most importantly avoids a situation when running `./bin/setup_venv.sh`
from the root where the system python will be hooked for the venv.
@4141done 4141done force-pushed the change-venv-location branch from ff3deeb to b3a2c10 Compare May 10, 2022 17:49
@qdzlug qdzlug merged commit 752f169 into nginxinc:master May 12, 2022
@qdzlug qdzlug mentioned this pull request May 12, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@dekobon dekobon dekobon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4141done @dekobon @qdzlug
0