8000 feat: add minikube jenkinsfile and test by qdzlug · Pull Request #127 · nginxinc/kic-reference-architectures · GitHub
[go: up one dir, main page]
Skip to content

feat: add minikube jenkinsfile and test #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2022
Merged

feat: add minikube jenkinsfile and test #127

merged 5 commits into from
Apr 19, 2022

Conversation

qdzlug
Copy link
Contributor
@qdzlug qdzlug commented Apr 18, 2022

Proposed changes

Created Jenkinsfile to enable minikube automatic deployment; fixed minor issue in AWS Jenkinsfile.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

4141done
4141done approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor
@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small optional comments around ease of use for troubleshooting steps. Otherwise all other comments are just questions to help me understand your thinking/the tooling.

@qdzlug qdzlug merged commit 082d6c8 into nginxinc:master Apr 19, 2022
@qdzlug qdzlug deleted the minikube branch April 19, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4141done 4141done 4141done approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qdzlug @4141done
0