E545 chore: bump setuptools to fix setup_venv.sh failures by qdzlug · Pull Request #122 · nginxinc/kic-reference-architectures · GitHub
[go: up one dir, main page]
Skip to content

chore: bump setuptools to fix setup_venv.sh failures #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

chore: bump setuptools to fix setup_venv.sh failures #122

merged 1 commit into from
Apr 12, 2022

Conversation

qdzlug
Copy link
Contributor
@qdzlug qdzlug commented Apr 11, 2022

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue
on GitHub, make sure to include a link to that issue here in this description
(not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

4141done
4141done approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor
@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍
This looks good to me. Fair warning that I've not run it, but going over the changelog for setuptools it does not appear that we'd be hit by any of the breaking changes introduced in 61 and 62

@qdzlug qdzlug merged commit 3c3926f into nginxinc:master Apr 12, 2022
@qdzlug qdzlug deleted the jaymisc branch April 12, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4141done 4141done 4141done approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qdzlug @4141done
0