feat: add draft jenkinsfiles to MARA #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
March 8, 2022 12:53
feat: add jenkinsfile support
test: using local jenkinsfile branch
test: move jenkinsfile
dekobon
approved these changes
Mar 9, 2022
| @@ -1,5 +1,8 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| set -x | |||
10BC0
There was a problem hiding this comment.
Are these lines supposed to be here?
extras/jenkins/README.md
Outdated
|
|
||
| ## Purpose | ||
|
|
||
| This directory contains a set of Jenkinsfiles that can be used with MARA. These should be considered to be in a "draft" |
There was a problem hiding this comment.
Linking out to something that explains what a Jenkinsfile does would be useful. Also, you may want to rephrase this so you do not pluralize Jenkinsfile because that's confusing due to it being a filename convention.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This change adds in a selection of Jenkinsfiles that are used internally by the MARA team for build testing. These are designed to checked out by Jenkins and then used to run the build process (opposed to them being stored completely in Jenkins). These are pipeline jobs. Documentation has been updated for this change.
A helper script has been added for the management of AWS credentials; the startup process currently does not handle the combination of AWS env variables and the on-disk .aws profiles/configs. This script reads the environment variables passed down from Jenkins and creates a credentials file from that information. Note that this does not have any impact on the manual build process (unless the user desires). This is expected to go away with the rewrite from #80
Additionally, there is one minor change to the AWS/DO build/deployment process; this addresses a bug that was introduced with the initial check-in.
Checklist
Before creating a PR, run through this checklist and mark each as complete.