-
Notifications
You must be signed in to change notification settings - Fork 103
Pulumi README copyedits #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
pulumi/python/README.md
Outdated
|
||
This project uses the NGINX KIC v2.x releases which includes full support for the GA APIs. do not use the | ||
This project uses the NGINX KIC v2.x releases which includes full support | ||
for the GA APIs. Do not use the [???] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence didn't have anything where I inserted [???]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I wonder what I was thinking there? Just go ahead and take out the whole sentence "Do not use the...".
I think that I wanted to say that you should not use the Beta API's, but I don't know that it's necessary to draw that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, I removed it in the new commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two little notes there, but other wise looks great. I'll merge once you update with those.
Jay
pulumi/python/README.md
Outdated
|
||
This project uses the NGINX KIC v2.x releases which includes full support for the GA APIs. do not use the | ||
This project uses the NGINX KIC v2.x releases which includes full support | ||
for the GA APIs. Do not use the [???] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I wonder what I was thinking there? Just go ahead and take out the whole sentence "Do not use the...".
I think that I wanted to say that you should not use the Beta API's, but I don't know that it's necessary to draw that out.
Fixed "reimplementation of the deployment here should be easily reproducible" sentence and removed "Do not use the" sentence.
Resolved both of these. I think I did it in the correct workflow with a new commit, but feel free to lmk if there's a better way. |
Proposed changes
Light copyedits on Pulumi ReadMe.
Checklist
Before creating a PR, run through this checklist and mark each as complete.