E542 Pulumi README copyedits by sarahrivka · Pull Request #100 · nginxinc/kic-reference-architectures · GitHub
[go: up one dir, main page]

Skip to content

Conversation

sarahrivka
Copy link
Contributor

Proposed changes

Light copyedits on Pulumi ReadMe.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have written my commit messages in the Conventional Commits format.
  • I have read the CONTRIBUTING doc
  • I have added tests (when possible) that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork


This project uses the NGINX KIC v2.x releases which includes full support for the GA APIs. do not use the
This project uses the NGINX KIC v2.x releases which includes full support
for the GA APIs. Do not use the [???]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence didn't have anything where I inserted [???]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I wonder what I was thinking there? Just go ahead and take out the whole sentence "Do not use the...".

I think that I wanted to say that you should not use the Beta API's, but I don't know that it's necessary to draw that out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok great, I removed it in the new commit.

Copy link
Contributor
@qdzlug qdzlug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little notes there, but other wise looks great. I'll merge once you update with those.

Jay


This project uses the NGINX KIC v2.x releases which includes full support for the GA APIs. do not use the
This project uses the NGINX KIC v2.x releases which includes full support
for the GA APIs. Do not use the [???]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, I wonder what I was thinking there? Just go ahead and take out the whole sentence "Do not use the...".

I think that I wanted to say that you should not use the Beta API's, but I don't know that it's necessary to draw that out.

Fixed "reimplementation of the deployment here should be easily reproducible" sentence and removed "Do not use the" sentence.
@sarahrivka
Copy link
Contributor Author

Two little notes there, but other wise looks great. I'll merge once you update with those.

Jay

Resolved both of these. I think I did it in the correct workflow with a new commit, but feel free to lmk if there's a better way.

@qdzlug qdzlug merged commit 414962b into nginxinc:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0