8000 ci: python 3.12+ compatibility by SchoNie · Pull Request #2566 · nginx-proxy/nginx-proxy · GitHub
[go: up one dir, main page]

Skip to content

ci: python 3.12+ compatibility #2566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Conversation

SchoNie
Copy link
Contributor
@SchoNie SchoNie commented Dec 18, 2024

Python 3.9 will reach EOL 31 Oct 2025. But in my environment they already removed it. And the tests were failing because of distutils.version is deprecated since Python 3.10 and removed in Python 3.12

distutils.version should be replaced with the packaging package

This makes the test suite compatible with Python 3.12 and also 3.13. But since Python 3.13 is not cached in the action runner image I used Python 3.12 for now.

Changed the python module version check to 7.0.0 as that adds official compatibility. And we use 7+ anyway.

8000
ci: python 3.12+ compatibility
ci: bump python module docker version check
@buchdag buchdag added type/ci PR that change the CI configuration files and scripts type/test PR that add missing tests or correct existing tests labels Dec 18, 2024
@buchdag buchdag merged commit c60eff5 into nginx-proxy:main Dec 18, 2024
2 checks passed
@buchdag
Copy link
Member
buchdag commented Dec 18, 2024

Thanks !

@SchoNie SchoNie deleted the python3.12+ branch December 18, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/ci PR that change the CI configuration files and scripts type/test PR that add missing tests or correct existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0