fix: add proto to VIRTUAL_HOST_MULTIPORTS #2561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Rolf-MP I pushed the |
Thanks a lot for picking this up - much appreciated! Absolutely will test/use it - will probably be early January but will post feedback. |
I tested is and it works smoothly - thank you! Great that my workaround with an additional proxy container to unlock the upstream service can be omitted now. Would be great if this makes it into the main branch! |
|
@Rolf-MP I'll try to add tests to this and merge it ASAP. |
43da2a0 to
403251c
Compare
403251c to
34a33a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed in #2552, nginx-proxy currently only handle different protocols at the container level even when using multiple ports with
VIRTUAL_HOST_MULTIPORTS.This PR fix that by adding optional
prototoVIRTUAL_HOST_MULTIPORTS.