8000 Support TCP and UDP proxy by KagurazakaNyaa · Pull Request #2078 · nginx-proxy/nginx-proxy · GitHub
[go: up one dir, main page]

Skip to content

Support TCP and UDP proxy #2078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Support TCP and UDP proxy #2078

merged 1 commit into from
May 8, 2024

Conversation

KagurazakaNyaa
Copy link
Contributor

Add including to the root of nginx.conf to facilitate adding configuration outside the http module.

@p12tic
Copy link
Contributor
p12tic commented May 4, 2024

@buchdag Are there any clear requirements (e.g. tests) which prevent this PR from landing? Or is it that the benefit of this feature is simply not clear and thus polishing the PR does not make sense? I could do whatever is necessary to get this feature merged. Thanks a lot!

@buchdag buchdag added the type/feat PR for a new feature label May 5, 2024
@buchdag
Copy link
Member
buchdag commented May 6, 2024

@p12tic a test would be nice but the PR seems rather straightforward to me, the main issue is rather that it conflicts with the current code ... and that I completely failed to notice it. I'll try to fix the merge conflicts this week.

@buchdag buchdag self-assigned this May 6, 2024
@p12tic
Copy link
Contributor
p12tic commented May 6, 2024

I'll try to fix the merge conflicts this week.

I can create a separate PR with merge conflicts fixed (the authorship of the code remains with KagurazakaNyaa of course).

@buchdag
Copy link
Member
buchdag commented May 6, 2024

No need to, I just rebased the branch and fixed the conflict.

Could you review the PR and check that I did not botch anything ?

@p12tic
Copy link
Contributor
p12tic commented May 7, 2024

Thanks. I will add a test in a subsequent PR.

@buchdag buchdag merged commit ec405f3 into nginx-proxy:main May 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feat PR for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0