Supply max_fails=0 on all server entries #1496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasSko
added a commit
to AndreasSko/infrastructure
that referenced
this pull request
Sep 3, 2020
AndreasSko
added a commit
to AndreasSko/infrastructure
that referenced
this pull request
Sep 3, 2020
AndreasSko
added a commit
to AndreasSko/infrastructure
that referenced
this pull request
Sep 3, 2020
AndreasSko
added a commit
to AndreasSko/infrastructure
that referenced
this pull request
Sep 3, 2020
AndreasSko
added a commit
to AndreasSko/infrastructure
that referenced
this pull request
Sep 3, 2020
If nginx-proxy is run on a host whose docker config has multiple networks, then it will generate an additional server XXX down; entry in each upstream for networks on which the container _isn't_. Having more than one server entry in an upstream invokes nginx's max_fails/fail_timeout behavior, which will mark the only live upstream server as down for 10s if it returns ONE error response. Instead, we want nginx to keep retrying the live upstream server regardless of what it returns, since there's nothing else to try. Passing "max_fails=0" on each live server entry disables the max_fails/fail_timeout behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If nginx-proxy is run on a host whose docker config has multiple
networks, then it will generate an additional
server XXX down;
entry in each upstream for networks on which the container isn't.
Having more than one server entry in an upstream invokes nginx's
max_fails/fail_timeout behavior, which will mark the only live
upstream server as down for 10s if it returns ONE error response.
Instead, we want nginx to keep retrying the live upstream server
regardless of what it returns, since there's nothing else to try.
Passing "max_fails=0" on each live server entry disables the
max_fails/fail_timeout behavior.
Fixes #1495.