E53F Add pre-commit and fix issues by lucacome · Pull Request #354 · nginx/nginx-prometheus-exporter · GitHub
[go: up one dir, main page]
Skip to content

Add pre-commit and fix issues #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2023
Merged

Add pre-commit and fix issues #354

merged 2 commits into from
Feb 1, 2023

Conversation

lucacome
Copy link
Contributor
@lucacome lucacome commented Jan 31, 2023 •
edited
Loading

Adds pre-commit configuration and fixes all the problems found by pre-commit run --all-files

@github-actions github-actions bot added chore Pull requests for routine tasks docs labels Jan 31, 2023
@lucacome lucacome force-pushed the chore/add-pre-commit branch from dfc8833 to f6ca514 Compare January 31, 2023 03:15
@lucacome lucacome force-pushed the chore/add-pre-commit branch from f9c6a20 to 6d23fcf Compare January 31, 2023 03:19
@lucacome lucacome marked this pull request as ready for review January 31, 2023 03:21
@lucacome lucacome self-assigned this Jan 31, 2023
@lucacome lucacome requested a review from a team as a code owner January 31, 2023 17:43
@lucacome lucacome merged commit 0c29bc8 into main Feb 1, 2023
@lucacome lucacome deleted the chore/add-pre-commit branch February 1, 2023 17:07
@lucacome lucacome mentioned this pull request Feb 1, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

@vepatel vepatel vepatel approved these changes

+1 more reviewer

@jasonwilliams14 jasonwilliams14 jasonwilliams14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacome @ciarams87 @jasonwilliams14 @vepatel
0