E541 Retire vendoring by lucacome · Pull Request #83 · nginx/nginx-asg-sync · GitHub
[go: up one dir, main page]
Skip to content

Retire vendoring #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2021
Merged

Retire vendoring #83

merged 2 commits into from
Apr 8, 2021

Conversation

lucacome
Copy link
Contributor
@lucacome lucacome commented Apr 6, 2021
  • Removed vendor folder and modified CI/build process accordingly
  • Removed Go version from CI, reading the version from go.mod
  • Added trimpath and ldflags to go build

There are two commits for readability, it will be squashed when merging.

@lucacome lucacome requested a review from a team April 6, 2021 23:31
@lucacome lucacome self-assigned this Apr 6, 2021
@lucacome lucacome requested review from pleshakov and ciarams87 and removed request for a team April 6, 2021 23:31
@github-actions github-actions bot added chore Pull requests for routine tasks dependencies Pull requests that update a dependency file documentation Pull requests/issues for documentation labels Apr 6, 2021
@lucacome lucacome removed the documentation Pull requests/issues for documentation label Apr 6, 2021
@lucacome lucacome enabled auto-merge (squash) April 7, 2021 00:03
@lucacome lucacome merged commit d33bd79 into master Apr 8, 2021
@ciarams87 ciarams87 deleted the chore/remove-vendor-folder branch April 8, 2021 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciarams87 ciarams87 ciarams87 approved these changes

+1 more reviewer

@pleshakov pleshakov pleshakov approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@lucacome lucacome

Labels
chore Pull requests for routine tasks dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucacome @pleshakov @ciarams87
0