8000 Add profile option for AWS by lucacome · Pull Request #730 · nginx/nginx-asg-sync · GitHub
[go: up one dir, main page]
Skip to content

Add profile option for AWS #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 28, 2024
Merged

Add profile option for AWS #730

merged 2 commits into from
Aug 28, 2024

Conversation

lucacome
Copy link
Contributor

Proposed changes

Adds profile option to AWS config.

Closes #320

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the enhancement Pull requests for new features/feature enhancements label Jul 27, 2024
@lucacome lucacome mentioned this pull request Jul 27, 2024
Closed
@lucacome lucacome force-pushed the feat/add-aws-profile branch from ea0e1ee to 3b85f21 Compare August 20, 2024 01:48
@lucacome lucacome force-pushed the feat/add-aws-profile branch from 4b9c7a5 to ce0478f Compare August 24, 2024 23:29
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Aug 24, 2024
@lucacome lucacome marked this pull request as ready for review August 25, 2024 00:46
@lucacome lucacome requested a review from a team as a code owner August 25, 2024 00:46
@lucacome lucacome self-assigned this Aug 25, 2024
@lucacome lucacome merged commit aa0358d into main Aug 28, 2024
13 checks passed
@lucacome lucacome deleted the feat/add-aws-profile branch August 28, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjberman sjberman sjberman approved these changes

Assignees

@lucacome lucacome

Labels

documentation Pull requests/issues for documentation enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cross account ASG access

2 participants

@lucacome @sjberman
0