8000 Replace deprecated command with environment file by jongwooo · Pull Request #311 · nginx/nginx-asg-sync · GitHub
[go: up one dir, main page]
Skip to content

Replace deprecated command with environment file #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

Replace deprecated command with environment file #311

merged 1 commit into from
Feb 27, 2023

Conversation

jongwooo
Copy link
Contributor

Proposed changes

Resolve #310

Update .github/workflows/ci.yml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

run: echo "::set-output name=go_path::$(go env GOPATH)"

TO-BE

run: echo "go_path=$(go env GOPATH)" >> $GITHUB_OUTPUT

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jongwooo jongwooo requested a review from a team as a code owner February 26, 2023 15:05
jongwooo
jongwooo commented Feb 26, 2023
View reviewed changes
Copy link
Contributor Author
@jongwooo jongwooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also nginxinc/nginx-prometheus-exporter#368

@lucacome lucacome self-assigned this Feb 27, 2023
@lucacome lucacome added the chore Pull requests for routine tasks label Feb 27, 2023
@lucacome lucacome merged commit a46347f into nginx:main Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lucacome lucacome lucacome approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lucacome lucacome

Labels

chore Pull requests for routine tasks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file

2 participants

@jongwooo @lucacome
0