8000 Add support for Azure VMSS by Rulox · Pull Request #24 · nginx/nginx-asg-sync · GitHub
[go: up one dir, main page]
Skip to content

Add support for Azure VMSS #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Add support for Azure VMSS #24

merged 1 commit into from
Aug 30, 2019

Conversation

Rulox
Copy link
Contributor
@Rulox Rulox commented Aug 27, 2019

Proposed changes

The agent can work now with Azure VirtualMachineScaleSets.

I have updated the README with the Azure configuration. As discussed internally I think it makes sense to split AWS and Azure configuration (both for the provider API auth and config file). This will be done in a different commit in the same PR once the current doc is reviewed.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Rulox Rulox added the enhancement Pull requests for new features/feature enhancements label Aug 27, 2019
@Rulox Rulox self-assigned this Aug 27, 2019
pleshakov
pleshakov suggested changes Aug 28, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rulox thx! Please see my comments

pleshakov
pleshakov approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving.
See a few small suggestions about the docs. If you think they make sense, please implement them before merging

@Rulox Rulox merged commit 430d395 into master Aug 30, 2019
@Rulox Rulox deleted the azure-vmss branch August 30, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Rulox Rulox

Labels

enhancement Pull requests for new features/feature enhancements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rulox @pleshakov @Dean-Coakley
0