8000 Improve documentation https usage by Dean-Coakley · Pull Request #965 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Improve documentation https usage #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 25, 2020
Merged

Improve documentation https usage #965

merged 2 commits into from
May 25, 2020

Conversation

Dean-Coakley
Copy link
Contributor
@Dean-Coakley Dean-Coakley commented May 22, 2020 •
edited
Loading

Proposed changes

  • Remove usage of the to be deprecated kubectl exec syntax

Example:

$ kubectl exec -it PODNAME bash
kubectl exec [POD] [COMMAND] is DEPRECATED and will be removed in a future version. Use kubectl kubectl exec [POD] -- [COMMAND] instead.
$
$ kubectl exec -it PODNAME -- bash
$

kubectl version:

Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T23:35:15Z", GoVersion:"go1.14.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:48:36Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
  • Use https in docs/examples where applicable

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto master
  • I will ensure my PR is targeting the master branch and pulling from my branch from my own fork

@Dean-Coakley Dean-Coakley self-assigned this May 22, 2020
@Dean-Coakley Dean-Coakley added the documentation Pull requests/issues for documentation label May 22, 2020
pleshakov
pleshakov approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Rulox
Rulox approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor
@Rulox Rulox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dean-Coakley Dean-Coakley merged commit 9b1af26 into master May 25, 2020
@Dean-Coakley Dean-Coakley deleted the docs-improvments branch May 25, 2020 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacome lucacome Awaiting requested review from lucacome

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

2 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Rulox Rulox Rulox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Dean-Coakley Dean-Coakley

Labels
documentation Pull requests/issues for documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dean-Coakley @pleshakov @Rulox
0