8000 Chore: use https url by imba-tjd · Pull Request #946 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Chore: use https url #946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2020
Merged

Chore: use https url #946

merged 3 commits into from
May 14, 2020

Conversation

imba-tjd
Copy link
Contributor

Trivial

@pleshakov pleshakov requested a review from LorcanMcVeigh May 12, 2020 21:24
Dean-Coakley
Dean-Coakley suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor
@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I think it also makes sense to update the following to use https too, makes sense @imba-tjd ?

https://github.com/nginxinc/kubernetes-ingress/blame/146d839bf2121e952857d86e8f306f59ade0ac30/docs-web/third-party-modules/opentracing.md#L3

https://github.com/nginxinc/kubernetes-ingress/blame/146d839bf2121e952857d86e8f306f59ade0ac30/docs-web/overview.md#L20

@imba-tjd
Copy link
Contributor Author

@Dean-Coakley Done. I didn't clone but edited them directly on GitHub, so feel free to squash this.

@imba-tjd imba-tjd changed the title Readme: use https url Chore: use https url May 13, 2020
Dean-Coakley
Dean-Coakley approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor
@Dean-Coakley Dean-Coakley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

lucacome
lucacome approved these changes May 13, 2020
View reviewed changes
Copy link
@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dean-Coakley Dean-Coakley merged commit 8aea490 into nginx:master May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pleshakov pleshakov Awaiting requested review from pleshakov

@Rulox Rulox Awaiting requested review from Rulox

@LorcanMcVeigh LorcanMcVeigh Awaiting requested review from LorcanMcVeigh

2 more reviewers

@lucacome lucacome lucacome approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imba-tjd @lucacome @Dean-Coakley
0