8000 Add Openshift Dockerfile for NGINX Plus by Rulox · Pull Request #857 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Add Openshift Dockerfile for NGINX Plus #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2020
Merged

Add Openshift Dockerfile for NGINX Plus #857

merged 1 commit into from
Feb 25, 2020

Conversation

Rulox
Copy link
Contributor
@Rulox Rulox commented Feb 25, 2020

Proposed changes

This PR adds a new DockerfileForPlus under the build/openshift folder. This Dockerfile is to build an ubi-based image for NGINX Plus. This is intended for Openshift clusters only.

martialonline
martialonline approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor
@martialonline martialonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

pleshakov
pleshakov approved these changes Feb 25, 2020
View reviewed changes
Copy link
Contributor
@pleshakov pleshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Rulox Rulox merged commit 1691194 into master Feb 25, 2020
@Rulox Rulox deleted the os-dockerfiles branch February 25, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tellet tellet Awaiting requested review from tellet

3 more reviewers

@pleshakov pleshakov pleshakov approved these changes

@Dean-Coakley Dean-Coakley Dean-Coakley approved these changes

@martialonline martialonline martialonline approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rulox @pleshakov @Dean-Coakley @martialonline
0