-
Notifications
You must be signed in to change notification settings - Fork 2k
add globalConfigurationCustomName parameter #8142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mohamadaldawamnah
merged 27 commits into
main
from
feature/global-config-custom-name-validation
Aug 27, 2025
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
45b91bf
Helm: add globalConfigurationCustomName parameter
frantsao 34ffce9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] fe07870
Remove unneeded comment in values.yaml
frantsao d0620e6
moved globalConfigurationCustomName parameter to globalConfiguration.…
frantsao 5156092
Fix values.schema.json format
frantsao 2b81c69
Helm: add globalConfigurationCustomName parameter
frantsao a73f946
Helm: add globalConfigurationCustomName parameter
frantsao 089e37d
adding validation and testing for global conifugration submitted by c…
mohamadaldawamnah 4218155
add global configuration customName tests
mohamadaldawamnah 5d4556e
add snapshot file for testing customnames
mohamadaldawamnah c042083
Update charts/nginx-ingress/templates/_helpers.tpl
mohamadaldawamnah 8cf9e2e
Update charts/nginx-ingress/templates/_helpers.tpl
mohamadaldawamnah a7b308c
resolving issues mentioned by github copilot
mohamadaldawamnah 7907d46
resolving issues mentioned by github copilot
mohamadaldawamnah ff4cef0
fixing linting format
mohamadaldawamnah 5376dd5
changing If statment and making sure it can be reached
mohamadaldawamnah 0aed68b
Update charts/nginx-ingress/templates/_helpers.tpl
mohamadaldawamnah fb8f8dd
Update charts/nginx-ingress/templates/_helpers.tpl
mohamadaldawamnah 69c4789
fixing copilot mentioned error
mohamadaldawamnah 7f6203a
Update charts/nginx-ingress/templates/_helpers.tpl
mohamadaldawamnah 3f242c3
fixing copilot mentioned error
mohamadaldawamnah 14cc1ac
Fix formatting and remove merge conflict markers
mohamadaldawamnah 66d0fed
fixed some testing issues
mohamadaldawamnah bd9f67c
fixed some testing issues
mohamadaldawamnah bf20392
fixed make cover issue
mohamadaldawamnah 564a826
added some annotation validation
mohamadaldawamnah c31fdde
Revert "added some annotation validation"
mohamadaldawamnah File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.