8000 Status updates for VS endpoints by github-actions[bot] · Pull Request #8079 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Status updates for VS endpoints #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

Status updates for VS endpoints #8079

merged 1 commit into from
Jul 28, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Proposed changes

Closes #8073

cm:

Name:         test-release-nginx-ingress
Namespace:    default
Data
====
external-status-address:
----
10.0.0.2

before:

NAME       STATE   HOST                   IP              PORTS      AGE
cafe       Valid   cafe-vs.example.com    10.0.0.2        [80,443]   33m <- New VS
keycloak   Valid   keycloak.example.com   35.233.10.138   [80,443]   24h <- Old VS
webapp     Valid   webapp.example.com     35.233.10.138   [80,443]   24h <- Old VS

after:

NAME       STATE   HOST                   IP         PORTS      AGE
cafe       Valid   cafe-vs.example.com    10.0.0.2   [80,443]   33m
keycloak   Valid   keycloak.example.com   10.0.0.2   [80,443]   24h
webapp     Valid   webapp.example.com     10.0.0.2   [80,443]   24h

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the bug An issue reporting a potential bug label Jul 28, 2025
@github-actions github-actions bot requested a review from a team as a code owner July 28, 2025 09:22
@github-actions github-actions bot added go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch bug An issue reporting a potential bug labels Jul 28, 2025
@vepatel vepatel changed the title [cherry-pick] fix status updates for VS endpoints fix status updates for VS endpoints Jul 28, 2025
@vepatel vepatel closed this Jul 28, 2025
@vepatel vepatel reopened this Jul 28, 2025
@github-actions github-actions bot removed the bug An issue reporting a potential bug label Jul 28, 2025
@vepatel vepatel added the bug An issue reporting a potential bug label Jul 28, 2025
@codecov Codecov
Copy link
codecov bot commented Jul 28, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-5.1@0c792c5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/k8s/status.go 72.72% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff               @@
##             release-5.1    #8079   +/-   ##
==============================================
  Coverage               ?   52.97%           
==============================================
  Files                  ?       90           
  Lines                  ?    21746           
  Branches               ?        0           
==============================================
  Hits                   ?    11519           
  Misses                 ?     9748           
  Partials               ?      479

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Jul 28, 2025
@vepatel vepatel merged commit df1d71e into release-5.1 Jul 28, 2025
72 checks passed
@vepatel vepatel deleted the cherry-pick-release-5.1-1a46fb9bd33ccecdb43f4a86b096d4bb4cc0e95e branch July 28, 2025 12:01
@pdabelf5 pdabelf5 changed the title fix status updates for VS endpoints Status updates for VS endpoints Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@AlexFenlon AlexFenlon AlexFenlon approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vepatel @AlexFenlon @pdabelf5
0