8000 Update interval checks for mgmt directive by github-actions[bot] · Pull Request #8046 · nginx/kubernetes-ingress · GitHub
[go: up one dir, main page]
Skip to content

Update interval checks for mgmt directive #8046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

Update interval checks for mgmt directive #8046

merged 1 commit into from
Jul 18, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Proposed changes

  • Add checks to not accept d as a valid duration
  • Add max time interval check

closes: #7988

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked tha 8000 t all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch labels Jul 18, 2025
@github-actions github-actions bot requested a review from a team as a code owner July 18, 2025 14:25
@github-actions github-actions bot added bug An issue reporting a potential bug go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch labels Jul 18, 2025
@pdabelf5 pdabelf5 removed the needs cherry pick Cherry pick this PR into a release branch label Jul 18, 2025
@vepatel vepatel changed the title [cherry-pick] update interval checks update interval checks Jul 18, 2025
@vepatel vepatel closed this Jul 18, 2025
@vepatel vepatel reopened this Jul 18, 2025
@github-actions github-actions bot added helm_chart Pull requests that update the Helm Chart and removed bug An issue reporting a potential bug labels Jul 18, 2025
@codecov Codecov
Copy link
codecov bot commented Jul 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-5.1@cceb6ec). Learn more about missing BASE report.

Additional details and impacted files 
@@              Coverage Diff               @@
##             release-5.1    #8046   +/-   ##
==============================================
  Coverage               ?   52.97%           
==============================================
  Files                  ?       90           
  Lines                  ?    21740           
  Branches               ?        0           
==============================================
  Hits                   ?    11517           
  Misses                 ?     9746           
  Partials               ?      477

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vepatel vepatel enabled auto-merge (squash) July 18, 2025 14:33
@vepatel vepatel merged commit 39558b8 into release-5.1 Jul 18, 2025
72 checks passed
@vepatel vepatel deleted the cherry-pick-release-5.1-2e5d5e95ded0d79981c43a1aaaf5a1a43e00c4c2 branch July 18, 2025 15:01
@pdabelf5 pdabelf5 changed the title update interval checks Update interval checks Aug 14, 2025
@pdabelf5 pdabelf5 added bug An issue reporting a potential bug and removed go Pull requests that update Go code helm_chart Pull requests that update the Helm Chart labels Aug 14, 2025
@vepatel vepatel changed the title Update interval checks Update interval checks for mgmt directive Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@pdabelf5 pdabelf5 pdabelf5 approved these changes

Assignees
No one assigned
Labels
bug An issue reporting a potential bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vepatel @pdabelf5
0